Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1329 (I): Cover art mouseovers don't display in some pages/elements #2650

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

amCap1712
Copy link
Member

Improve the logic for choosing the thumbnail link and title for mouseovers in certain cases. This fixes the two top albums pages.

For playlist pages, we forgot to send the release name/album field in the playlist data. Add that.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that'll do it !

@MonkeyDo
Copy link
Contributor

MonkeyDo commented Dec 4, 2023

I'll not that this is set to be merged into the fix-links branch, just in case that wasn't on purpose

Base automatically changed from fix-links to master December 4, 2023 18:45
@amCap1712
Copy link
Member Author

Yup that was only to ease PR review.

Improve the logic for choosing the thumbnail link and title for mouseovers in
certain cases. This fixes the two top albums pages.

For playlist pages, we forgot to send the release name/album field in the playlist
data. Add that.
@amCap1712 amCap1712 merged commit e9b305e into master Dec 4, 2023
3 checks passed
@amCap1712 amCap1712 deleted the fix-thumbnails branch December 4, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants