Modals: remove backdrop class manually when closing modals #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to removing the modal from the DOM tree to conserve resources, I broke the bootstrap/jquery mechanism that removes the "modal-open" class that is automatically added to the body element in the page. Since the DOM elements are removed, the event callback that removes the class isn't fired, so we need to fire it manually. Let's move to React-Bootstrap soon and avoid all this bullshit, shall we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to removing the modal from the DOM tree to conserve resources , I broke the bootstrap/jquery mechanism that removes the "modal-open" class that is added to the HTML body element when we open a modal (#2772 made the timeout shorter).
Since the DOM elements are removed, the event callback that removes the class isn't fired, so we need to fire it manually.
Let's move to React-Bootstrap soon and avoid all this bullshit, shall we?