LB-1495: lb-radio endpoint is affected by letter case #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amCap1712
reviewed
Mar 18, 2024
| @@ -722,6 +722,7 @@ def get_tags_dataset(): | |||
| tag = request.args.getlist("tag") | |||
| if tag is None: | |||
| raise APIBadRequest("tag param is missing") | |||
| tag = [t.lower() for t in tag] | |||
There was a problem hiding this comment.
I am not sure if all tag names in the database are lower cased. I'll check if that is the case, then the fix would work. If not, a case insensitive match should be performed in the SQL query. Will update.
There was a problem hiding this comment.
It appears that all tags are in fact lowercase:
musicbrainz_db=# select count(distinct(lower(name))) from tag;
count
--------
213811
(1 row)
musicbrainz_db=# select count(*) from tag;
count
--------
213811
(1 row)
|
I feel that this isn't a problem that should be fixed in ListenBrainz, its a troi problem. I've fixed this in troi, so closing this PR. Thanks for submitting the PR, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Basically, upper case tag won't do anything. For example: https://api.listenbrainz.org/1/lb-radio/tags?tag=Jazz&begin_percent=0&end_percent=50&count=50 gives 0 results. It's because PG's WHERE clause is case-sensitive.
Solution
Convert all tags into lower case when loading the query params. Also add a integration test for this endpoint.