Single page application feature branch #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver into spa-entity-pages
…inz/listenbrainz-server into spa-entity-pages
…erver into spa-entity-pages
…erver into spa-entity-pages
Single page app fixes
Otherwise, ToastContainer and NiceModal both won't have access to any of the react-router context, which breaks if you use a Link component for example, or want a 'refetch' button in a toast messsage.
Noiw that we navigate with react-router, the modal backdrop ends up staying open after navigation, making the page pretty much useless. So close the modal on click, and also ensure when you click the backdrop it closes the modal
Otherwise our "back" buttons at the top of the page take you back to the redirect and back to the album page you just came from
This is so the secondary navbar can span the whole width rather than be constrained to a max width; since this is what we want for the rest of the content, we have applied the role="main" attribute everywhere and we can use that.
MonkeyDo
commented
Apr 25, 2024
There was a problem hiding this comment.
Haven't tested this page at all, I didn't even know it existed!
It's for the old (deprecated?) LastFM API compatibility.
Will see how to try it out
| </div> | ||
| <br /> | ||
| <div className="well" style={{ maxWidth: "600px", margin: "0 auto" }}> | ||
| <a |
There was a problem hiding this comment.
Just checking that we do indeed want an anchor tag here and not a Link. Makes sense, but I thought I'd check since the login is pretty crucial and we don't often use it ourselves
|
|
||
| describe("ListensControls", () => { | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| xdescribe("ListensControls", () => { |
There was a problem hiding this comment.
I'll have to revisit this, with #2844 and the HueSound refactor I've learned a lot about how to test this stuff, but it's going to take me a bit of time
This prevents the navbar and the footer from re-rendering on switching between protected and public routes.
This is used with CSS to limit the width of the main page content
BrowserRouter goes first so that everything inside (such as toast messages) can have access to react-router context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #2731, except this time we split the work into a few PRs, and reviewed and merged them into a feature branch.
The components of this PR have been reviewed and tested manually, and this PR is mainly to have a paper trail.
PRs in this feature branch:
#2769
#2822