Refactor HueSound into a functional component #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ rename from ColorPlay to HueSound
+Reorganize BrowserRouter so that ToastContainer has router context
12 tasks
anshg1214
requested changes
May 1, 2024
Can't click on elements rendered on a canvas in tests, so pass an optional color + finishing tests
Replace the initialColor prop I had put in to be able to run tests, and instead test with the router and URL params directly
|
I ended up refactoring a bit more to allow having a color in the URL params. That way it also makes it possible to test the component, because we can't interact with the colorwheel (rendered canvas) in tests to select a color. |
|
Note that this component is refactored to play nice with react-router, but has not been refactored to be used with the new BrainzPlayer with queues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the userfeed-refactor branch, wait for #2844 to be merged please