Send the correct playing_now listen metadata #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and not the metadata of the previous track *facepalm*
MonkeyDo
added a commit
that referenced
this pull request
May 16, 2024
After a merge conflict resolution. See #2859 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and not the metadata of the previous track facepalm
The issue is that even though we call
setStateearlier in the function, the state values are not updated by the time we callsubmitNowPlayingToListenBrainzand the track metadata is still that of the previous track.Thankfully this was only an issue with playing_now listens which are by nature transient.