Fix release colors update #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping database in the config is an outdated replica of MB db that hasn't been updated in 6 months probably because the dumps DB was moved to a new node, but we still have the old coordinates hardcoded. Change it to use MB standby instead. The process_row function had a bug in downloading and processing the images. Mostly stylistic changes other than that.
|
Hello @amCap1712! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Review with hide whitespace for better view. |
mayhem
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping database in the config is an outdated replica of MB db that hasn't been updated in 6 months probably because the dumps DB was moved to a new node, but we still have the old coordinates hardcoded. Change it to use MB standby instead.
The process_row function had a bug in downloading and processing the images.
Mostly stylistic changes other than that.