Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soundcloud metadata cache #2922

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Add soundcloud metadata cache #2922

merged 4 commits into from
Jul 1, 2024

Conversation

amCap1712
Copy link
Member

Similar to the spotify and apple metadata caches, add a metadata cache for Soundcloud. Unlike other services, Soundcloud does not have albums as a primitive. Most of the API endpoints revolve around users (artists) and tracks.

The initial seeding of the crawler is done using tracks trending across various categories/genres in Soundcloud. The track's artist is retrieved and then the artist's all uploaded tracks are fetched and inserted in the cache. The artist's following lists and likes are also scanned to find new users for the crawler to scan.

Also, refactor the base handlers and crawler as soundcloud cache is created without albums.

Similar to the spotify and apple metadata caches, add a metadata cache for
Soundcloud. Unlike other services, Soundcloud does not have albums as a
primitive. Most of the API endpoints revolve around users (artists) and tracks.

The initial seeding of the crawler is done using tracks trending across
various categories/genres in Soundcloud. The track's artist is retrieved and
then the artist's all uploaded tracks are fetched and inserted in the cache.
The artist's following lists and likes are also scanned to find new users for
the crawler to scan.

Also, refactor the base handlers and crawler as soundcloud cache is created
without albums.
@amCap1712 amCap1712 requested a review from mayhem June 26, 2024 18:31
@pep8speaks
Copy link

pep8speaks commented Jun 26, 2024

Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:22: E261 at least two spaces before inline comment
Line 21:21: E261 at least two spaces before inline comment
Line 141:5: E303 too many blank lines (2)

Line 9:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-07-01 08:14:18 UTC

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@amCap1712 amCap1712 merged commit cd905e2 into master Jul 1, 2024
2 checks passed
@amCap1712 amCap1712 deleted the soundcloud-cache branch July 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants