LB-240: Dump sanitized version of the user table in the stats dump #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed the three columns ( |
|
I think that will still make the FK's fail upon import. We'll need to keep the columns, but put blank and/or dummy values in. For instance, in MB, when we need to dump the passwd field, we dump the data with all the passwords effectively set of "mb". We should probably do the same here. |
Now the stats dump will contain dummy values for each of the sensitive columns in the table.
mayhem
approved these changes
Nov 15, 2017
| # dump in the stats dump | ||
| '\'auth_token\'', # auth token | ||
| 'to_timestamp(0)', # last_login | ||
| 'to_timestamp(0)', # latest_import |
There was a problem hiding this comment.
I was too tired yesterday when I tried to understand this -- it feels a little odd, but in the general this is a clever way of solving the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to import the stats dump in absence of a corresponding private dump.
Ideally, this should be reviewed and merged before #274, so that I can rebase and make the changes required to the import process after the extra table is added to the stats dump.