Attributes for candidate recording dumps #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansika
added a commit
that referenced
this pull request
Jan 30, 2020
* used mbids->msids mapping in create_dataframes used pyspark API over sql queries * fixed bad indent * Use combined mapping (recording_artist_msid_mbid) and not recording and artist mapping independently * Use artist_credit_artist_credit relation and recording_artist_mbid_msid mapping to generate recommendations * vertical align pyspark functions to increase readability * Update utils.py * Unit test listenbrainz_spark/recommendations (#74) * add tests for create_dataframes modify utils to avoid prepending hdfs_cluster_uri to every path * unit tests for create_dataframes * unit tests for train models * Add tests for request consumer and fix test.sh path problems (#72) * Add first test for request consumer * Use python -m pytest instead of py.test py.test doesn't add the current dir to PYTHONPATH which is why if you try to add a test anywhere other than listenbrainz_spark/tests you'll get an import error. this fixes that problem. * fix definition of self * Import create_app * Add test for get_result * declared constant var as a class member changed class names for consistency changed test_get_dates... to assert difference used assertListEqual for lists removed wildcard imports typos and newlines * unit tests for candidate_sets.py and recommend.py * defined date as an instance variable Co-authored-by: Param Singh <iliekcomputers@gmail.com> * upload mappings, artist relation and listens to HDFS (#77) * download listens and mapping from FTP upload listens and mapping to HDFS * calculate time taken to download files from ftp * correct listenbrainz listens dump path on ftp * add misiing import and remove extra func arg * upload and download script for artist relation * add *force* utility to delete existing data * rectify name of imports, delete unused import files * update tests and recommendation engine with mdis_mbid_mapping * use NotImplementedException to catch null callback * Add archival warning * Unit tests for HDFS/FTP module (#698) * download listens and mapping from FTP upload listens and mapping to HDFS * calculate time taken to download files from ftp * correct listenbrainz listens dump path on ftp * add misiing import and remove extra func arg * upload and download script for artist relation * add *force* utility to delete existing data * rectify name of imports, delete unused import files * update tests and recommendation engine with mdis_mbid_mapping * use NotImplementedException to catch null callback * tests for ftp downloader and hdfs uploader for mapping, listens, artist relations * update func name in utils and add test for it * Fix startup script of spark-request-consumer * add pxz.wait to avoid race condiiton modified utils.create_dataframe to warp spark row object in list * improve function names * define constants on top of file and import them in tests Co-authored-by: Param Singh <iliekcomputers@gmail.com> * Attributes for candidate recording dumps (#710) * get attributes for candidate recoridngs dump * update unit tests with changes in recommed.py * typo in function name * import utils as module and not attribute Co-authored-by: Param Singh <iliekcomputers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are moving towards our first release, yay!
As a first step, we need to fetch all the attributes that will make up the schema.
Schema
This PR gets all the required attributes while generating recommendations.