Port LastFm importer to typescript #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsingh
approved these changes
Apr 11, 2020
paramsingh
added a commit
that referenced
this pull request
Apr 11, 2020
* First cut at converting api-service.js to typescript * Convert APIService.test.js to TypeScript * Fix tests and add maximum stack depth * Fix test files * Fixed the tests in APIService.ts * Fix tests in Importer.test.ts * Tests for LastFMImporter fixed * All tests pass * Add package-lock.json and update entrypoint * Port LastFm importer to typescript (#787) * Port type.ts to type.d.ts * Fix ESLint errors * Fix LastFM importer icons (#788) * Fix icons * Disable no-unused-vars * Add tests for skipping listens if non 429 error codes Co-authored-by: Ishaan Shah <ishaanshah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port LastFm importer to TypeScript.
Problem
Our javascript has no types and it is very hard to understand the code (or write new code)
Solution
Slowly convert everything to TypeScript.