Fix RecentListens snapshot test #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsingh
approved these changes
Apr 13, 2020
paramsingh
reviewed
Apr 14, 2020
Mount renders child components too. The Spotify Player was causing some warnings to pop up. As we are testing Spotify Player in it's own snapshot test and we want the tests to be independent, I think we should use |
paramsingh
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue with failing snapshot test for RecentListens
Problem
The timestamp on RecentListens is calculated relative to the current time. This cause the snapshot tests to fail as the timestamp changes.
Solution
Mocking the
timago.agofunction to return a constant value make the snapshot test independent ofcurrent time