Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make payload content requirements more explicit #833

Merged
merged 1 commit into from May 4, 2020

Conversation

Zastai
Copy link
Contributor

@Zastai Zastai commented May 4, 2020

Based on comment on the PR for LB-511.

For single/playing-now, use "exactly one" instead of "only one".
For import, explicitly state "at least one", and reword the item describing the document size limit.

This also makes line spacing and indentation consistent across the three parts.

For single/playing-now, use "exactly one" instead of "only one".
For import, explicitly state "at least one", and reword the item describing the document size limit.

This also makes line spacing and indentation consistent across the three parts.
Copy link
Collaborator

@paramsingh paramsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better than what I had, thanks!

@paramsingh paramsingh merged commit 69ab2a3 into metabrainz:master May 4, 2020
@Zastai Zastai deleted the patch-1 branch May 4, 2020 19:22
@alastair
Copy link
Collaborator

alastair commented May 4, 2020

this looks great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants