Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup kafka bits & Fix tests setup #87

Merged
merged 10 commits into from
Jul 4, 2016

Conversation

pinkeshbadjatiya
Copy link
Contributor

No description provided.

@pinkeshbadjatiya pinkeshbadjatiya changed the title [WIP] More cleanup + Fix tests More cleanup + Fix tests Jul 1, 2016
@pinkeshbadjatiya pinkeshbadjatiya changed the title More cleanup + Fix tests Cleanup kafka bits & Fix tests setup Jul 1, 2016
@mayhem
Copy link
Member

mayhem commented Jul 4, 2016

The code for creating the test db in manage.py isn't correct:

Creating database and user for testing...
psql: could not connect to server: No such file or directory
Is the server running locally and accepting
connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?
Traceback (most recent call last):
File "manage.py", line 180, in
cli()
File "/usr/local/lib/python2.7/site-packages/click/core.py", line 664, in call
return self.main(_args, *_kwargs)
File "/usr/local/lib/python2.7/site-packages/click/core.py", line 644, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python2.7/site-packages/click/core.py", line 991, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python2.7/site-packages/click/core.py", line 837, in invoke
return ctx.invoke(self.callback, *_ctx.params)
File "/usr/local/lib/python2.7/site-packages/click/core.py", line 464, in invoke
return callback(_args, **kwargs)
File "manage.py", line 99, in init_test_db
raise Exception('Failed to create new database and user! Exit code: %i' % exit_code)
Exception: Failed to create new database and user! Exit code: 2

Take a look at the init_db function -- it passes more arguments on the command line. You'll need to pass the same arguments in the create test db function as the regular one.

@mayhem
Copy link
Member

mayhem commented Jul 4, 2016

Looks good to me!

@mayhem mayhem merged commit aac58f7 into metabrainz:master Jul 4, 2016
@pinkeshbadjatiya pinkeshbadjatiya deleted the fix_tests_cleanup branch August 3, 2016 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants