Add GitHub action to test packaging MB Solr with Maven #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
approved these changes
Feb 27, 2024
amCap1712
reviewed
Feb 27, 2024
amCap1712
reviewed
Feb 27, 2024
amCap1712
reviewed
Feb 27, 2024
The `touch` command prevents Maven from regenerating the Java binding which would then be missing the changes from `utils/patch-java-classes`. See commit 44dbb10 for details.
Use the same Eclipse Temurin distribution as in the Dockerfile (for both Maven builder image and Solr final image).
Note that building `mb-solr` with `mvn package` is running the tests under the directory `mb-solr/src/test/` but these are mentionned after 12k+ lines of logs and for some reason searching logs through GitHub (feature in Beta) is currently helpless.
Reference: https://github.com/actions/setup-java/releases Co-authored-by: Kartik Ohri <kartikohri13@gmail.com>
Reference: https://github.com/actions/setup-java#caching-maven-dependencies Co-authored-by: Kartik Ohri <kartikohri13@gmail.com>
yvanzo
force-pushed
the
github-action
branch
from
c147952
to
2b3a124
Compare
See message in commit 33d0cf8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There used to be continuous integration tests in Travis, but these have not been maintained and Travis isn’t free anymore since 2021.
Solution
A good first step for restoring those tests is to be able to build and install MusicBrainz Solr package with Maven.