This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
MSP-3: Redirect / to project page on GitHub #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Freso
force-pushed
the
MSP-3-redirect-index-page-to-github
branch
from
f567de7
to
5537be5
Compare
mayhem
approved these changes
Jun 17, 2017
|
@brainzbot, add to whitelist. |
Freso
force-pushed
the
MSP-3-redirect-index-page-to-github
branch
from
5537be5
to
ee24695
Compare
gentlecat
reviewed
Jun 17, 2017
mbspotify/views_test.py
Outdated
| # Index page should ask users to piss off. | ||
| self.assertIn("Piss off!", str(response.data)) | ||
| # Index page should redirect visitors to the project page on GitHub. | ||
| self.assertRedirects(302, "https://github.com/metabrainz/mbspotify") |
There was a problem hiding this comment.
You might be able to check the status separately. Check docs for that function at https://pythonhosted.org/Flask-Testing/.
There was a problem hiding this comment.
Yeah, I misread the docs there. Should be fixed in new commit. :)
Freso
force-pushed
the
MSP-3-redirect-index-page-to-github
branch
from
ee24695
to
4231790
Compare
gentlecat
approved these changes
Jun 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new HTML page as in #35 just makes / do a 302 redirect to GitHub page.