Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEARCH-685 (SolrCloud): Update cores’ common config after Solr 9 #65

Merged
merged 3 commits into from
May 9, 2024

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Apr 11, 2024

Problem

Even though it isn’t blocking SEARCH-685, the following issues matter for SolrCloud deployment:

  1. Some settings under common/ were obsolete for a long time.
  2. Some settings couldn’t be quickly changed.

Solution

  1. Use NRTCachingDirectoryFactory
  2. Use overridable parameters

Additional change

Remove deprecated enableRemoteStreaming which was set to false, the default value anyway.

References

atj added 3 commits April 3, 2024 16:45
This change enables query result and document cache parameters to be
customised via core properties.
This stops deprecation warnings from being printed in the logs. Remote
streaming is disabled by default for security reasons, so the attribute
is not needed:

https://github.com/apache/solr/blob/c512116f6a20b3ccd0c76c0743053553da2ff53b/solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java#L116-L117C7
Copy link
Contributor Author

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are authored by @atj, reviewed by me. (But since I opened this pull request, I cannot formally select the Approve button.)

@yvanzo yvanzo merged commit d77fe96 into metabrainz:master May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants