Reactify sign up and profile forms #437
Conversation
This comment has been minimized.
This comment has been minimized.
|
Not to merge in master, just for review and then close. |
There was a problem hiding this comment.
Looks good at a glance. I tested on test and read through the PR.
I haven't used Formik before so take the review with a grain of salt :D
However everything I tested worked fine, except a broken link (not introduced in this PR).
Broken link is on the /login page, the "Create a free MetaBrainz account" links to /Login with a capital L, which A) is a broken link and B) probably wouldn't be the right link anyway since I'm already on /login
|
The early form validation works great! |
|
I'm not sure what is the right PR (if any) for the actual sign up form for a non-supporter account, but the error messages there were inconsistent when I tested it (some were uppercased, some lowercase, etc) but it otherwise worked fairly well. |
Use formik library to aid in reactifying the forms. This is useful in providing form validation feedback to the user without requiring the user to submit it first.
|
@reosarevok I haven't opened a PR for that yet. |
Use formik library to aid in reactifying the forms. This is useful in providing form validation feedback to the user without requiring the user to submit it first.