Fixed : Unable to scroll in landscape mode on Search page. #62
Conversation
7phalange7
commented
Jan 7, 2021
7phalange7
commented
- fixed issue - https://tickets.metabrainz.org/browse/MOBILE-59?jql=project%20%3D%20MOBILE
- Added scroll view outside relative layout and formatted (ctrl + alt + L )
|
PTAL @amCap1712 |
|
The fix seems to be working. It seems that the buttons below the search box are sized unevenly. Can you please fix that as well so that the buttons are equally sized ? |
Done |
|
Looks great! I'll try to test this on my device during the weekend. |
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/app_bg"> | ||
|
|
||
| <FrameLayout | ||
| android:id="@+id/search_fragment_layout" | ||
| <RelativeLayout |
There was a problem hiding this comment.
The changes look good to me. I think we should convert this layout to use a ConstraintLayout instead of RelativeLayout. Would you like to take that up? I am happy to merge the changes either ways.
There was a problem hiding this comment.
Yeah, converting the layout to constraint layout will be good. I'll take it up and push the changes asap.
|
PTAL @amCap1712 |
|
Thanks for the contribution! |
