Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created two new plugins #8

Closed
wants to merge 1 commit into from
Closed

Conversation

dstrohl
Copy link

@dstrohl dstrohl commented Jan 5, 2015

one to remove and save anything that is at 80+% accurate, the other to remove anything that is less than 80% (without saving)

In both cases they will also remove albums that are empty (leaving ones that still have unmatched files).

both have a number of debug messages in them, which can be removed it it makes sense.

@phw
Copy link
Member

phw commented Jan 29, 2015

You should add some source code license information to your code. We already have too many plugins which don't specify a license, which makes it hard to distribute and reuse the code. See issue #5 .

Otherwise I haven't looked too close into the code, but I like the functionality.

@zas
Copy link
Collaborator

zas commented Jan 30, 2015

Imho it would be better to create 2 separated PRs for those plugins, with explicit title for each.
And, as said by @phw , please add :

PLUGIN_LICENSE = "your license"
PLUGIN_LICENSE_URL = "your license url (if any)"

Format isn't yet normalized, but i think it is a good start (see http://tickets.musicbrainz.org/browse/PICARD-703)

@zas
Copy link
Collaborator

zas commented Aug 22, 2015

@dstrohl ?

@dstrohl
Copy link
Author

dstrohl commented Aug 25, 2015

sorry, I missed the notification of these.. I will take a look and add the license info and update the pull requests.

@zas
Copy link
Collaborator

zas commented Jan 12, 2017

sorry, I missed the notification of these.. I will take a look and add the license info and update the pull requests.

@dstrohl : ping ? ;)

@zas zas added the new plugin label Jan 12, 2017
@zas
Copy link
Collaborator

zas commented Jan 19, 2017

No update from author, closing.

@zas zas closed this Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants