PICARD-1379: Fix PyUnicode_GetSize deprecation warning in astrcmp #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PyUnicode_GetLength instead of deprecated PyUnicode_GetSize. Requires Python >= 3.3
zas
reviewed
Oct 18, 2018
picard/util/_astrcmp.c
Outdated
| @@ -156,8 +156,8 @@ astrcmp(PyObject *self, PyObject *args) | |||
|
|
|||
| us1 = PyUnicode_AS_UNICODE(s1); | |||
| us2 = PyUnicode_AS_UNICODE(s2); | |||
There was a problem hiding this comment.
Isn't this also deprecated ?
https://docs.python.org/3/c-api/unicode.html#c.PyUnicode_AS_UNICODE
There was a problem hiding this comment.
Indeed it is. There was just no warning output, probably because these are macros. I will update the PR
Requires Python >= 3.3
|
I updated the module for the new Unicode API. For a quick speed comparison I measured running the unit test function 1 million times. On my system:
So a slight performance decrease of 3%. But for comparison the Python implementation takes roughly 186 seconds for the same call count. |
phw
force-pushed
the
PICARD-1379-fix-astrcmp-deprecation-warnings
branch
from
652d40c
to
03758c0
Compare
|
Sorry, this needs more work. I just realized my patch breaks the threading |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
PyUnicode_GetLengthinstead of deprecatedPyUnicode_GetSize. Requires Python >= 3.3, but we list Python 3.5 as the minimum anyway.Problem
Solution
Action