PICARD-2130: Refactor cover art options #1757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The cover art options are currently not quite clear and can be confusing:
cover_image_filename
input. If this input is empty Picard will fall back to use just "cover" as filename, and having this placeholder text helpsSolution
caa_image_type_as_filename
toimage_type_as_filename
and move it to the global Cover optionscaa_save_single_front_image
tosave_only_one_front_image
and move it to the global Cover options. This is consistent with the similarembed_only_one_front_image
option.save_only_one_front_image
is enabled deactivate theimage_type_as_filename
checkbox, as it no longer applies (no non-front images will be saved)cover_image_filename
input. If this input is empty Picard will fall back to use just "cover" as filename, and having this placeholder text helps