Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and extend artists tag ... #268

Merged

Conversation

Sophist-UK
Copy link
Contributor

  1. artists tag is incorrectly added to a release - now added only to a track
  2. add _artists_sort, _albumartists and _albumartists_sort for use in scripts and plugins.

This PR addressed PICARD-582 http://tickets.musicbrainz.org/browse/PICARD-582

1. artists tag is incorrectly added to a release - now added only to a
track
2. add _albumartists and _albumartists_sort for use in scripts and
plugins.
zas added a commit that referenced this pull request Apr 3, 2014
@zas zas merged commit 6922848 into metabrainz:master Apr 3, 2014
Sophist-UK added a commit to Sophist-UK/picard that referenced this pull request Apr 3, 2014
@Sophist-UK Sophist-UK mentioned this pull request Apr 3, 2014
@mwiencek
Copy link
Member

mwiencek commented Apr 3, 2014

We don't use _sort in albumsort, albumartistsort, artistsort, titlesort, composersort, or showsort, so the underscore seems inconsistent.

@Sophist-UK
Copy link
Contributor Author

yes - but I did it deliberately this way because artists ends with an s and I thought that _albumartistssort was too easily mis-spelled as _albumartistsort.

But I am not that bothered either way and I can do a PR to change this easily enough.

@Sophist-UK Sophist-UK deleted the sophist_fix_and_extend_artists_tag branch April 3, 2014 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants