Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-1204: Fix shoddy lock handling while reading config values #853

Closed
wants to merge 1 commit into from

Conversation

@samj1912
Copy link
Member

@samj1912 samj1912 commented Mar 1, 2018

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

We were returning the value before ever releasing the lock.

Solution

Release the lock properly and then return the value.

Action

@samj1912 samj1912 requested a review from zas Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant