Added a much shorter time for killing idle in transaction procs

metabrainz · Aug 1, 2012 · 7bf6f5b · ocharles · Aug 1, 2012 · ocharles
1 parent 561b287
commit 7bf6f5b
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/process-reaper/reap-long-processes.pl b/process-reaper/reap-long-processes.pl
@@ -7,12 +7,13 @@
 
 use DBI;
 
-my ($warn, $limit) = @ARGV;
+my ($warn, $limit, $idle) = @ARGV;
 my %warn_pids;
 
-(($warn || 0) > 0 && ($limit || 0) > 0) or
-    die "Usage: reap-long-processes.pl <warn> <limit>
+(($warn || 0) > 0 && ($idle || 0) > 0) or
+    die "Usage: reap-long-processes.pl <warn> <limit> <idle>
 <warn> and <limit> are the amount of seconds before warning/killing processes
+<idle> is the amount of time before killing idle transactions
 ";
 
 my $dbh = DBI->connect('dbi:Pg:dbname=postgres;host=127.0.0.1', 'postgres')
@@ -37,13 +38,18 @@
                 scalar(localtime), $stuck->{procpid}, $warn;
             printf "%s Query: %s\n", scalar(localtime), $stuck->{current_query};
             $warn_pids{$stuck->{procpid}} = $stuck->{query_start};
+            if ($stuck->{current_query} eq "<IDLE> in transaction" && scalar(localtime) > $idle) {
+                printf "%s ERROR Idle in transaction process %d has been running for over %d seconds. Killing!\n",
+                    scalar(localtime), $stuck->{procpid}, $idle;
+                $dbh->do("SELECT pg_terminate_backend(?)", $stuck->{procpid});
+            }
         }
 
         if ($stuck->{kill}) {
             printf "%s ERROR Process %d has been running for over %d seconds. Killing!\n",
                 scalar(localtime), $stuck->{procpid}, $limit;
             printf "%s Query: %s\n", scalar(localtime), $stuck->{current_query};
-            kill(15, $stuck->{procpid});
+            $dbh->do("SELECT pg_terminate_backend(?)", $stuck->{procpid});
         }
     }