Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the stats that are not fetching metadata #110

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix the stats that are not fetching metadata #110

merged 2 commits into from
Aug 11, 2023

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Aug 11, 2023

Was checking for "", should be None.

Also, remove debug prints

@mayhem mayhem requested a review from amCap1712 August 11, 2023 14:02
@github-actions

This comment has been minimized.

Sign in to view
amCap1712
amCap1712 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

troi/musicbrainz/recording_lookup.py Outdated Show resolved Hide resolved
@mayhem mayhem merged commit 3c424ea into main Aug 11, 2023
1 check passed
@mayhem mayhem deleted the stats-fix branch August 11, 2023 14:05
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
50 tests ±0  50 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c424ea. ± Comparison against base commit 3c424ea.

MonkeyDo
MonkeyDo approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See, python feels just like javascript sometimes :)

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

@amCap1712 amCap1712 amCap1712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mayhem @MonkeyDo @amCap1712