New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit an album key in JSPF if we don't have album info. #113

Merged

mayhem merged 7 commits into main from fix-empty-album-string

Oct 30, 2023

Member

mayhem commented Oct 25, 2023

If the key exists, but is empty LB will refuse to accept that as a listen. So not emitting the album key when we dont have an album fixes this.


          Do not emit an album key in JSPF if we don't have album info.

81f446e

mayhem requested a review from MonkeyDo

October 25, 2023 14:30

This comment has been minimized.

Sign in to view


          Now include albums

d375dd4

This comment has been minimized.

Sign in to view

MonkeyDo reviewed

View reviewed changes

troi/playlist.py Outdated Show resolved Hide resolved


          Update troi/playlist.py

19c07f3

Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>

This comment has been minimized.

Sign in to view


          Actually copy over the data for releases

d793f49

This comment has been minimized.

Sign in to view


          Deal with possible Nones

d16e032

This comment has been minimized.

Sign in to view

mayhem marked this pull request as ready for review

October 26, 2023 15:02


          Fix tests

a1b133f

This comment has been minimized.

Sign in to view

mayhem requested a review from MonkeyDo

October 26, 2023 15:20

MonkeyDo approved these changes

View reviewed changes

Contributor

MonkeyDo left a comment

Results look good on beta.LB (testing with LB Radio tracks which first shined a light on the lack of release info)

MonkeyDo reviewed

View reviewed changes

troi/playlist.py Outdated Show resolved Hide resolved


          Remove debug

137eed2

This comment has been minimized.

Sign in to view

mayhem merged commit a0ca6f9 into main

2 checks passed

mayhem deleted the fix-empty-album-string branch

October 30, 2023 13:45

github-actions bot commented Oct 30, 2023

Unit Test Results

  1 files ±0   1 suites ±0 0s ⏱️ ±0s
50 tests ±0 50 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a0ca6f9. ± Comparison against base commit a0ca6f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment