Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup #47

Merged
merged 2 commits into from Apr 11, 2022
Merged

General cleanup #47

merged 2 commits into from Apr 11, 2022

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Apr 11, 2022

This PR does the following things:

  1. Remove all components that use AB.
  2. Move the YIM components to an internal folder so that they are out of the way for day-to-day sort of stuff. We really only need them for YIM times.
  3. Fix the failing test for the MBID mapping

Move YIM stuff to interal folder.
@mayhem mayhem requested a review from amCap1712 April 11, 2022 15:21
@github-actions

This comment has been minimized.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May rename internal to yim but otherwise LGTM. Also, the YIM patches may still be broken but those can be fixed later. Thanks!

@mayhem
Copy link
Member Author

mayhem commented Apr 11, 2022

I'm sure the YIM patches are broken, since the data doesn't exist. Which is why I wanted them out of the way -- and I am not fussed what we call that dir, as long as new comers don't get caught up in it.

@mayhem mayhem merged commit 4879eb1 into main Apr 11, 2022
@mayhem mayhem deleted the general-cleanup branch April 11, 2022 16:09
@github-actions
Copy link

Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
34 tests ±0  34 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4879eb1. ± Comparison against base commit 4879eb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants