Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metacall-node-port-test hangs with Node 15.x #118

Closed
jfblomgren opened this issue Apr 13, 2021 · 0 comments
Closed

metacall-node-port-test hangs with Node 15.x #118

jfblomgren opened this issue Apr 13, 2021 · 0 comments
Labels
bug Something isn't working c/c++ Pull requests that update C/C++ code

Comments

@jfblomgren
Copy link
Contributor

🐛 Bug Report

When running metacall-node-port-test with Node 15.x, the program hangs after the tests finish (note that the fail test fails on Node 15.x due to a change in the error message, so this test must be commented out to reproduce).

Expected Behavior

metacall-node-port-test should gracefully close after the tests finish.

Current Behavior

metacall-node-port-test hangs after the tests finish.

Possible Solution

Putting node_loader_impl_print_handles calls in node_loader_impl_destroy_prepare_cb and node_loader_impl_destroy_safe, @viferga suspects it has something to do with a signal handle that is created on Node 15.x but not on 10.x. Further testing showed that the signal was SIGWINCH, which - for unknown reasons - was created in spite of the terminal size remaining constant during execution.

Filtering out SIGWINCH in node_loader_impl_walk_async_handles_count causes the program to segfault after finishing the tests. AddressSanitizer does not pick up on anything, but running this commit with Valgrind gives this output.

Steps to Reproduce

  1. Comment out the fail test in source/ports/node_port/test/index.js
  2. Build metacall-node-port-test using Node 15.x
  3. Run metacall-node-port-test
@jfblomgren jfblomgren added the bug Something isn't working label Apr 13, 2021
@viferga viferga added the c/c++ Pull requests that update C/C++ code label Apr 22, 2021
@viferga viferga closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/c++ Pull requests that update C/C++ code
Projects
None yet
Development

No branches or pull requests

2 participants