You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running metacall-node-port-test with Node 15.x, the program hangs after the tests finish (note that the fail test fails on Node 15.x due to a change in the error message, so this test must be commented out to reproduce).
Expected Behavior
metacall-node-port-test should gracefully close after the tests finish.
Current Behavior
metacall-node-port-test hangs after the tests finish.
Possible Solution
Putting node_loader_impl_print_handles calls in node_loader_impl_destroy_prepare_cb and node_loader_impl_destroy_safe, @viferga suspects it has something to do with a signal handle that is created on Node 15.x but not on 10.x. Further testing showed that the signal was SIGWINCH, which - for unknown reasons - was created in spite of the terminal size remaining constant during execution.
Filtering out SIGWINCH in node_loader_impl_walk_async_handles_count causes the program to segfault after finishing the tests. AddressSanitizer does not pick up on anything, but running this commit with Valgrind gives this output.
Steps to Reproduce
Comment out the fail test in source/ports/node_port/test/index.js
Build metacall-node-port-test using Node 15.x
Run metacall-node-port-test
The text was updated successfully, but these errors were encountered:
🐛 Bug Report
When running
metacall-node-port-test
with Node 15.x, the program hangs after the tests finish (note that thefail
test fails on Node 15.x due to a change in the error message, so this test must be commented out to reproduce).Expected Behavior
metacall-node-port-test
should gracefully close after the tests finish.Current Behavior
metacall-node-port-test
hangs after the tests finish.Possible Solution
Putting
node_loader_impl_print_handles
calls innode_loader_impl_destroy_prepare_cb
andnode_loader_impl_destroy_safe
, @viferga suspects it has something to do with a signal handle that is created on Node 15.x but not on 10.x. Further testing showed that the signal was SIGWINCH, which - for unknown reasons - was created in spite of the terminal size remaining constant during execution.Filtering out SIGWINCH in
node_loader_impl_walk_async_handles_count
causes the program to segfault after finishing the tests. AddressSanitizer does not pick up on anything, but running this commit with Valgrind gives this output.Steps to Reproduce
fail
test insource/ports/node_port/test/index.js
metacall-node-port-test
using Node 15.xmetacall-node-port-test
The text was updated successfully, but these errors were encountered: