Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeJS tests in GitHub CI #364

Merged
merged 10 commits into from
Jan 12, 2023
Merged

Conversation

pkspyder007
Copy link
Contributor

Description

Adds NodeJS tests to run on CI
This is a partial fix for now, a couple of tests are still failing related to core.

@pkspyder007
Copy link
Contributor Author

We are ignoring the failure of this test as of now. It requires some work in the core as suggested by @viferga

The following tests FAILED:
Errors while running CTest
     44 - metacall-node-async-resources-test (SEGFAULT)

CI Logs for all other tests passing in windows for node are here

@viferga
Copy link
Member

viferga commented Jan 11, 2023

I want to merge this but before doing it by means of the script, it would be nice if we can implement this at CMake level, so it works out of the box.

@viferga viferga merged commit 8108bf2 into metacall:develop Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants