Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build with Python support for MacOS #391

Merged
merged 4 commits into from Mar 1, 2023

Conversation

ahmedihabb2
Copy link
Contributor

Description

Build Metacall with Python support for MacOS

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the

Note:

The following tests FAILED:
4 - log-custom-test (SEGFAULT)
33 - metacall-dynlink-path-test (Failed)
34 - metacall-library-path-without-env-vars-test (Failed)
you can view full logs from here

@viferga
Copy link
Member

viferga commented Mar 1, 2023

@ahmedihabb2 please use always tabs in shell scripts, do not mix tabs and spaces in a shell script, use spaces in yaml only.

@viferga viferga merged commit bb79a77 into metacall:develop Mar 1, 2023
@ahmedihabb2
Copy link
Contributor Author

@ahmedihabb2 please use always tabs in shell scripts, do not mix tabs and spaces in a shell script, use spaces in yaml only.

Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants