Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First PoC for solving threading issues in node loader. #502

Merged
merged 6 commits into from
May 23, 2024

Conversation

viferga
Copy link
Member

@viferga viferga commented May 17, 2024

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #(issue_no)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

@viferga viferga added bug Something isn't working c/c++ Pull requests that update C/C++ code labels May 17, 2024
@viferga viferga requested a review from devraymondsh May 17, 2024 15:26
@viferga viferga self-assigned this May 17, 2024
@viferga viferga marked this pull request as draft May 17, 2024 15:26
@viferga
Copy link
Member Author

viferga commented May 17, 2024

@devraymondsh do you want to close this PR: #500 in favor of this one?

@devraymondsh
Copy link
Member

@devraymondsh do you want to close this PR: #500 in favor of this one?

Sure.

Copy link
Member

@devraymondsh devraymondsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, the NodeJS loader needs some comprehensive refactoring that can be done later.

@viferga viferga marked this pull request as ready for review May 23, 2024 16:32
@viferga viferga merged commit e3a6bab into develop May 23, 2024
17 of 27 checks passed
@viferga viferga deleted the fix/node-multithread-deadlock branch May 23, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/c++ Pull requests that update C/C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants