rpcclient: add spentandmissedtickets notification #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metaclips
force-pushed
the
rpcclient/add_methods
branch
from
ae255de
to
fd2db69
Compare
metaclips
commented
Jan 30, 2022
Comment on lines
+139
to
+153
| notification_generator!( | ||
| "notify_spent_and_missed_tickets registers the client to receive notifications | ||
| when blocks are connected to the main chain and tickets are spent or missed. | ||
| The notifications are delivered to the notification handlers associated with the client. | ||
| Calling this function has no effect if there are no notification handlers and will result in | ||
| an error if the client is configured to run in HTTP POST mode. | ||
| \nThe notifications delivered as a result of this call will be those from OnSpentAndMissedTickets. | ||
| \n**NOTE: This is a dcrd extension and requires a websocket connection.**", | ||
| notify_spent_and_missed_tickets, | ||
| NotificationsFuture, | ||
| commands::METHOD_NOTIFY_SPEND_AND_MISSED_TICKETS, | ||
| &[], | ||
| all_defined(on_spent_and_missed_tickets), | ||
| () | ||
| ); |
There was a problem hiding this comment.
This is a macro that generates notification commands. It comprises of 7 parameter.
- Documentation of the notification command
- Function name (which here is notify_spent_and_missed_tickets)
- Future type (which normally is
NotificationsFuture - Command type as a string
- Notification parameters, which are to be sent as an array of
serde values - Notification handlers that must
all be defined (all of the provided handler must be defined)oreither be defined (one of the handlers must be defined) - Functions input parameter with their types.
| @@ -490,3 +509,69 @@ pub(super) fn on_tx_accepted_verbose( | |||
|
|
|||
| on_tx_verbose_callback(tx_details); | |||
| } | |||
|
|
|||
| pub(super) fn on_spent_and_missed_tickets( | |||
There was a problem hiding this comment.
On response from the server, the response parameters are treated appropriately.
Comment on lines
+756
to
+764
| commands::NOTIFICATION_METHOD_SPENT_AND_MISSING_TICKETS => { | ||
| match notif.on_spent_and_missed_tickets { | ||
| Some(e) => chain_notification::on_spent_and_missed_tickets(&msg.params, e), | ||
| None => { | ||
| warn!("on spent and missing tickets callback not registered."); | ||
| continue; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We pass the appropriate function OnNotification
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.