Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow group/host vars to work with ansible 1.9 #543

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Allow group/host vars to work with ansible 1.9 #543

merged 1 commit into from
Oct 7, 2016

Conversation

retr0h
Copy link
Contributor

@retr0h retr0h commented Oct 7, 2016

Ansible 1.9 cannot parse the yaml serialized by anyconfig, when
using the host/group vars functionality. Created a functional test
to cover this scenario.

@retr0h
Copy link
Contributor Author

retr0h commented Oct 7, 2016

/cc @signed8bit Using m9dicts.convert_to when returning the config object vs having to convert in various places.

@retr0h
Allow group/host vars to work with ansible 1.9
52011c8 
Ansible 1.9 cannot parse the yaml serialized by anyconfig, when
using the host/group vars functionality.  Created a functional test
to cover this scenario.

Also, set coverage properly.  This is not a regression.  We are at
79.83%, however, the report rounds up to 80%.
@retr0h
Copy link
Contributor Author

retr0h commented Oct 7, 2016 

  syntax: commands succeeded
  py27-ansible19-unit: commands succeeded
  py27-ansible19-functional: commands succeeded
  py27-ansible20-unit: commands succeeded
  py27-ansible20-functional: commands succeeded
  py27-ansible21-unit: commands succeeded
  py27-ansible21-functional: commands succeeded
  doc: commands succeeded

@signed8bit
Copy link
Contributor

👍

@retr0h retr0h merged commit d67c026 into ansible:master Oct 7, 2016
@retr0h retr0h deleted the ansible-19-group-vars branch October 7, 2016 18:21
retr0h added a commit that referenced this pull request Oct 10, 2016
@retr0h
Allow group/host vars to work with ansible 1.9 (#543)
6dd0f13 
Ansible 1.9 cannot parse the yaml serialized by anyconfig, when
using the host/group vars functionality.  Created a functional test
to cover this scenario.

Also, set coverage properly.  This is not a regression.  We are at
79.83%, however, the report rounds up to 80%.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retr0h @signed8bit