Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metacontroller should have a separate examples repo with proper e2e #2

Open
AmitKumarDas opened this issue May 21, 2020 · 3 comments
Open
Labels

Comments

@AmitKumarDas
Copy link
Contributor

No description provided.

@sathieu
Copy link
Contributor

sathieu commented Apr 12, 2021

@AmitKumarDas What is the difference between this bug and #4?

@grzesuav What about creating a metacontroller-contrib repo with user-contributed controllers? I've re-iplemented istio ingress conversions to gateway and virtualservice (because istio/istio#31817 was not accepted), and this would fit in it.

Not sure e2e tests are needed, but testing controllers against predefined inputs is definitively needed.

@AmitKumarDas
Copy link
Contributor Author

@sathieu This issue as well as #4 are pointing to same stuff. I was thinking to put these as two separate repos since library mode will be typical Golang based & will reduce the learning curve in the long run.

Note: metacontroller still does not support library mode. So contrib repo can be started off.

@grzesuav
Copy link
Contributor

@sathieu I am more keen to set up #85 for this purpose - as I do not think we will support all user-written controllers with their custom logic etc and offer bug fixing and feature requests - but we sure can put a place which can point to all that.

Also, this issue started at the beginning of migration, I am not sure how suitable would be to have metacontroller in one repo and e2e tests in the other as it will be a problem to keep it in sync, and intorducing changes to both in the same time and still having tests passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants