Packages with leading underscores not indexed

metacpan · Jan 28, 2015 · cdbdf04 · cdbdf04
1 parent 3f783f9
commit cdbdf04
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/MetaCPAN/Document/File.pm b/lib/MetaCPAN/Document/File.pm
@@ -704,6 +704,12 @@ does not include any modules, the L</indexed> property is true.
 sub set_indexed {
     my ( $self, $meta ) = @_;
 
+    foreach my $mod ( @{ $self->module } ) {
+        if ( $mod->name =~ /^[_*]/ ) {
+            $mod->indexed(0);
+        }
+    }
+
     foreach my $mod ( @{ $self->module } ) {
         $mod->indexed(
               $meta->should_index_package( $mod->name )

diff --git a/t/document/file.t b/t/document/file.t
@@ -171,6 +171,14 @@ END
     };
 };
 
+subtest 'Packages starting with underscore are not indexed' => sub {
+    my $file = MetaCPAN::Document::File->new( %stub,
+        module => { name => '_Package::Foo' } );
+
+    $file->set_indexed( CPAN::Meta->new( { name => 'null', version => 0 } ) );
+    is( $file->module->[0]->indexed, 0, 'Package is not indexed' );
+};
+
 subtest 'module below .../t/' => sub {
     my $file = MetaCPAN::Document::File->new(
         %stub,