[WIP] some hacks to allow indexing on ES 2.3 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later versions of ElasticSearchX::Model and Search::Elasticsearch have some mismatches (the first adjusted to ES1.X and the later to ES2.X)
|
|
||
| if ($@) { | ||
| my $author; |
There was a problem hiding this comment.
Would be nice to start using Try::Tiny here and Cpanel::JSON::XS
|
992cb30 needs metacpan/metacpan-puppet#98 and metacpan/metacpan-puppet#96 to be resolved. |
|
Let's merge this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the hacks used (except for local configuration files) to allow indexing on ES 2.3
I assume the indexing is not complete and this PR is only meant for the discussion and change reference for actual future changes.