Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve link choices for in-dist modules/pod #497

Merged
merged 1 commit into from Jun 20, 2016
Merged

improve link choices for in-dist modules/pod #497

merged 1 commit into from Jun 20, 2016

Conversation

haarg
Copy link
Member

@haarg haarg commented Jun 19, 2016

This is an improvement over my last attempt of providing in-dist links for non-indexed or non-latest pod.

@haarg haarg mentioned this pull request Jun 19, 2016
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.315% when pulling 90c992f on topic/permalinks into b67d768 on master.

@oalders
Copy link
Member

oalders commented Jun 20, 2016

@mickeyn would you like to review/merge this?

@mickeyn
Copy link
Contributor

mickeyn commented Jun 20, 2016

sure. we should probably want to start thinking of moving those queries to the API side, but other than that it seems fine.

@mickeyn mickeyn merged commit 8469888 into master Jun 20, 2016
@haarg haarg deleted the topic/permalinks branch July 12, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haarg @coveralls @oalders @mickeyn