Add web and simple search endpoints #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to metacpan-web's module-model's search method. This then needs to be wrapped into search_expanded, search_collapsed etc.
Also rename the web_like endpoint to simple. This needs reevaluation later.
these are the commits that were taken a15e24e51cabd710eca6a24c1c5214732101ef85 - boost (haarg) 4302a53b1d0a08cf5a41dcf19e9142877f366b13 - splice (oalders)
Also merge the model methods into one entry point. The frontend has previously munged the query, we take that munging now. From that we determine if the results should be expanded or collapsed based on the query itself. For flexibility we now also all explicitly passing a flag indicating whether we want collapsed results. Additionally we return in the data whether the results are actually expanded or collapsed for inspection which is especially useful when the backend decided what to do based on the query. Note that the result structure does not depend on collapsing or not, just the data contained within it.
oalders
approved these changes
Nov 22, 2016
| @@ -0,0 +1,484 @@ | |||
| package MetaCPAN::Model::Search; | |||
|
|
|||
| use Moose; | |||
There was a problem hiding this comment.
Any reason not to use MetaCPAN::Moose here? That gives you MooseX::StrictConstructor for free.
There was a problem hiding this comment.
The only reason I can think of is that I didn't know about it (also, I copied from MetaCPAN::Model::Release which does't use it).
There was a problem hiding this comment.
Cool. Maybe we can make that change later. It would be nice to use it where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web search is the true gain here, the simple search avoids most of the input and output aggregation and munging and is therefore easier to reason about for say search optimization.