Added /search/web/first API endpoint #711
Conversation
lib/MetaCPAN/Model/Search.pm
Outdated
| @@ -44,6 +44,16 @@ sub search_simple { | |||
| return $results; | |||
| } | |||
|
|
|||
| sub search_first { | |||
There was a problem hiding this comment.
Why is this called search_first? Can we give it a more descriptive name or add a comment?
There was a problem hiding this comment.
oh, that name was copied of search_simple & search_web.... it's basically search_simple but only returns the first element (so web doesn't have to dig through {hits}{hits} structures.
I don't mind changing it, any suggestions?
There was a problem hiding this comment.
In that case maybe even just search_for_first_result would convey what it's doing a little more clearly?
There was a problem hiding this comment.
Might be helpful to add a note explaining when or why we want to do this.
There was a problem hiding this comment.
i'll change the name as suggested.
just to be clear, it's the only usage of search_simple... so technically can be used only as a temp. name until we remove the need for search_simple
This will simplify the reading of /search/web/simple output by extracting the first element and eliminating the need for WEB to read an ES output structure.
mickeyn
force-pushed
the
mickey/search_first_endpoint
branch
from
2642c5d
to
e6b5c6e
Compare
This will simplify the reading of /search/web/simple output by
extracting the first element and eliminating the need for WEB
to read an ES output structure.