Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author search auto-complete is under "Products" label #1707

Closed
xsawyerx opened this issue Jun 9, 2016 · 5 comments
Closed

Author search auto-complete is under "Products" label #1707

xsawyerx opened this issue Jun 9, 2016 · 5 comments
Labels
priority:Low size: small type:Bug where:UI
Milestone
V1 - Elasticsearc...

Comments

@xsawyerx
Copy link
Contributor

xsawyerx commented Jun 9, 2016

[This applies to v1 too.]

Select "Authors" in the search box radio button. Write some author's name so auto-complete kicks in. The names appear under the label "Products".
@oalders
Copy link
Member

oalders commented Jun 9, 2016

@xsawyerx Thanks! Could you attach a screen shot?

@xsawyerx
Copy link
Contributor Author

xsawyerx commented Jun 9, 2016

metacpan-product

@oalders
Copy link
Member

oalders commented Jun 9, 2016

Wow. I never noticed that before. @danmcc is it possible to change that heading to "Authors"?

@danmcc
Copy link
Contributor

danmcc commented Jun 9, 2016

Definitely! You can do it via CSS:

#autocomplete-direct-results:before {
  content: 'Authors'
}

Looks like root/static/css/jquery.autocomplete.css is the place to put it.

xsawyerx added a commit that referenced this issue Jun 9, 2016
@xsawyerx
Fix auto-complete authors label in search:
e15dd2f 
Per GH #1707, when searching for authors, the auto-complete shows
the found results under a label "Products". This adds a CSS rule
to fix it and show them under a label "Authors".
@xsawyerx xsawyerx mentioned this issue Jun 9, 2016
Closed
xsawyerx added a commit that referenced this issue Jun 9, 2016
@xsawyerx
Fix auto-complete authors label in search:
a1c9b85 
Per GH #1707, when searching for authors, the auto-complete shows
the found results under a label "Products". This adds a CSS rule
to fix it and show them under a label "Authors".
@xsawyerx xsawyerx mentioned this issue Jun 9, 2016
Merged
xsawyerx added a commit that referenced this issue Jun 9, 2016
@xsawyerx
Fix auto-complete authors label in search:
1c37781 
Per GH #1707, when searching for authors, the auto-complete shows
the found results under a label "Products". This adds a CSS rule
to fix it and show them under a label "Authors".
@ranguard ranguard added this to the V1 - Elasticsearch 2.x milestone Jun 10, 2016
@xsawyerx
Copy link
Contributor Author

Fix merged. Closing.

Thank you. :)

oalders pushed a commit that referenced this issue Jun 11, 2016
@xsawyerx @oalders
Fix auto-complete authors label in search:
3a57b94 
Per GH #1707, when searching for authors, the auto-complete shows
the found results under a label "Products". This adds a CSS rule
to fix it and show them under a label "Authors".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:Low size: small type:Bug where:UI
Projects
None yet
Milestone
V1 - Elasticsearch 2.x
Development

No branches or pull requests
4 participants
@xsawyerx @ranguard @oalders @danmcc