Fix some bootstrap/layout issues on account pages #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buttons used some custom styles to make them equal width and some strange pads. Change to use `btn-block` from bootstrap to get block level buttons, which gives them equal width, and remove `btn-large` as they are plenty easy to hit without being large, and with there being so many of them in a row, this makes it a bit less in your face.
Collect related styles in one place, and reduce style.css, win-win!
The motivation was "remove check", which looked like one link to me. Now it is clearly two buttons, and one is red. I opted to not add `btn-danger` to the remove buttons that are on distinctive lines, as opposed to the profile where there are two buttons on each line.
The old conversion didn't really convert to bootstrap, only add form-horizontal class Here I convert all inputs to bootstrap markup, the buttons get converted to `input-append`, and I clean up a bit on the mobile version. I also convert all the profile icons to CSS from <img> tags, because I think they are layout, not content. I combined the LAt/Long into one line, because that makes more sense in my head :P
For email and url fields that is. Should make keyboards better on mobile devices
|
@omega could you attach a few screenshots to illustrate what the changes are? Just the "after" shots would be fine. |
|
|
|
|
|
The identities page can still use some work on mobile I noticed now, damn hard coded table widths etc.. |
|
Looks great! |
oalders
added a commit
that referenced
this pull request
Feb 25, 2014
Fix some bootstrap/layout issues on account pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 commits with increasing "invasiveness". The last one is by far the biggest change. I think they can be cherry-picked if people don't want to go "all in".
I think the new stuff looks better, but I realize that not everyone might agree.
The fifth commit is another small fix, but it won't work well without the others (I'm too lazy to rebase it earlier in the order)