Add higher resolution icons to favicon.ico #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a 32x32 and 48x48 icon to favicon.ico. It means the filesize increases slightly, but it also means that it looks nicer in Firefox, Safari and Chrome tabs. I also added apple-touch-icon (152x152, iOS7 retina version) if someone saves metacpan to their "home screen" on mobile devices, this icon will be used. The favicon.ico icons are transparent, the apple-touch-icon is on a white background. iOS uses a black background for transparent parts and that looked pretty damn awful.
|
Thanks very much! 👍 |
oalders
added a commit
that referenced
this pull request
Mar 13, 2014
Add higher resolution icons to favicon.ico
oiami
pushed a commit
to oiami/metacpan-web
that referenced
this pull request
Jun 9, 2014
Add higher resolution icons to favicon.ico
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 32x32 and 48x48 icon to favicon.ico. It means the filesize increases slightly,
but it also means that it looks nicer in Firefox, Safari and Chrome tabs.
I also added apple-touch-icon (152x152, iOS7 retina version) if someone saves metacpan
to their "home screen" on mobile devices, this icon will be used.
The favicon.ico icons are transparent, the apple-touch-icon is on a white background.
iOS uses a black background for transparent parts and that looked pretty damn awful.