Add dependency graph widget (via Stratopan) GH #1168 #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've simplifed the widget so you don't need to pass height and width dimensions any more. Just setting the size of the iframe should be sufficient.
|
I have added some caching on the Stratopan side. It should significantly reduce the load time in most cases. Like this beast: https://widgets.stratopan.com/wheel?q=Task::Dist::Zilla And there is some documentation here: https://stratopan.com/widgets |
|
Beautiful! Thank you. |
oalders
added a commit
that referenced
this pull request
May 12, 2014
Add dependency graph widget (via Stratopan) GH #1168
|
This doesn't work on the metacpan site because metacpan is served via HTTPS, but the iframe uses HTTP. |
oiami
pushed a commit
to oiami/metacpan-web
that referenced
this pull request
Jun 9, 2014
Add dependency graph widget (via Stratopan) GH metacpan#1168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "Dependency graph" link beneath the dependency list (but only if the release has dependencies). The graph itself appears in a modal that uses an iframe to load the content from Stratopan. This required adding
boostrap-modal.jsto the JS kit.These size of these graphs can vary greatly, so it was hard to come up with an interface that would accommodate most of them without being too obtrusive. There is a link to open the graph full-screen in a separate window, which is handy for large graphs.
Personally, I like the modal design because it doesn't take you away from the MetaCPAN site, and the iframe loads in the background so it (usually) feels very responsive. If you want to see something different, please let me know.
It looks right to me on latest Firefox, Chrome, and Safari. I haven't tested on older versions of those nor any version of IE or Opera.
On the Stratopan side, I have set up a separate application to serve this stuff (at http://widgets.stratopan.com). Currently there are 8 workers supporting it. If necessary, I can add more and/or rewrite it to be non-blocking.