Use correctly sized gravatars when possible #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a gravatar_fixup vmethod that accepts a pixel size to set on gravatar URLs. It also adjusts them to use HTTPS, replacing the existing repeated templated code.
|
I see the test suite isn't passing. One problem is that the Dist::Zilla search has been hijacked by Zilla::Dist https://metacpan.org/search?q=dist%3A%3Azilla :) |
|
There were some earlier test failures that were real, but the remaining ones are not related to this PR. |
|
@oalders For the "dist zilla" query that's used, Zilla::Dist is scored slightly by ES higher than Dist::Zilla, presumably because the words "dist" and "zilla" are found slightly more frequently or something. The request and response are here: https://gist.github.com/tsibley/863fc6ae99cd2bce151c Searching for "dist::zilla" has the same behaviour, but "Dist::Zilla" works as expected because Dist::Zilla gets a score boost from an exact package name match. |
|
Thanks! 👍 |
oalders
added a commit
that referenced
this pull request
May 27, 2014
Use correctly sized gravatars when possible
oiami
pushed a commit
to oiami/metacpan-web
that referenced
this pull request
Jun 9, 2014
Use correctly sized gravatars when possible
oiami
pushed a commit
to oiami/metacpan-web
that referenced
this pull request
Jun 9, 2014
Use correctly sized gravatars when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a gravatar_fixup vmethod that accepts a pixel size to set on
gravatar URLs. It also adjusts them to use HTTPS, replacing the
existing repeated templated code.