Search only by module name when a term is prefixed with "module:" #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expanded search (previously only used for searches within specific distributions) is used so that modules are not collapsed under their distributions. Someone searching for a list of modules doesn't want some of the modules elided from the results. Sorting of results is unchanged, but may want to be reconsidered later for module: searches after comparing, for example, the vast difference between module:MooseX::Types and module:MooseX::Type. While colons are special characters in Lucene's query syntax [1], I don't think we need to escape them in this case because the query term contains no spaces. Similarly, we don't seem to need to escape other special characters like hyphens in distribution names. [1] http://lucene.apache.org/core/2_9_4/queryparsersyntax.html#Escaping%20Special%20Characters
oalders
added a commit
that referenced
this pull request
Jul 11, 2014
Search only by module name when a term is prefixed with "module:"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expanded search (previously only used for searches within specific
distributions) is used so that modules are not collapsed under their
distributions. Someone searching for a list of modules doesn't want
some of the modules elided from the results.
Sorting of results is unchanged, but may want to be reconsidered later
for module: searches after comparing, for example, the vast difference
between module:MooseX::Types and module:MooseX::Type.
While colons are special characters in Lucene's query syntax [1], I
don't think we need to escape them in this case because the query term
contains no spaces. Similarly, we don't seem to need to escape other
special characters like hyphens in distribution names.
[1] http://lucene.apache.org/core/2_9_4/queryparsersyntax.html#Escaping%20Special%20Characters