consolidate JSON handling around JSON::MaybeXS, to provide a sane backend everywhere

app.psgi

@@ -18,7 +18,7 @@ use Config::JFDI;
 use FindBin;
 use lib "$FindBin::RealBin/lib";
 use File::Path   ();
-use JSON         ();
+use JSON::MaybeXS ();
 use MIME::Base64 ();
 use MetaCPAN::Web;
 use Plack::Builder;
@@ -78,7 +78,7 @@ my $app = Plack::App::URLMap->new;
 
             # Pass $_[0] since the json subs may have a ($) protoype.
             # Pass '' to base64 for a blank separator (instead of newlines).
-            MIME::Base64::encode( JSON::encode_json( $_[0] ), q[] );
+            MIME::Base64::encode( JSON::MaybeXS::encode_json( $_[0] ), q[] );
         },
         deserializer => sub {
 
@@ -87,7 +87,7 @@ my $app = Plack::App::URLMap->new;
 
             # Use try/catch so JSON doesn't barf if the cookie is bad.
             try {
-                JSON::decode_json( MIME::Base64::decode($cookie) );
+                JSON::MaybeXS::decode_json( MIME::Base64::decode($cookie) );
             }
 
             # No session.

cpanfile

@@ -39,7 +39,7 @@ requires 'HTTP::Request';
 requires 'HTTP::Request::Common';
 requires 'Hash::AsObject';
 requires 'Hash::Merge';
-requires 'JSON::XS', '3.01';
+requires 'JSON::MaybeXS', '1.002000';
 requires 'List::MoreUtils';
 requires 'List::Util';
 requires 'Locale::Country','3.28';

lib/MetaCPAN/Web/Controller/Account.pm

@@ -3,7 +3,7 @@ package MetaCPAN::Web::Controller::Account;
 use Moose;
 use List::MoreUtils qw(pairwise);
 use DateTime ();
-use JSON::XS ();
+use JSON::MaybeXS ();
 
 BEGIN { extends 'MetaCPAN::Web::Controller' }
 
@@ -78,7 +78,7 @@ sub profile : Local {
         for (qw(name asciiname gravatar_url city region country));
     $data->{$_} = [ grep {$_} $req->param($_) ] for (qw(website email));
     $data->{extra}
-        = eval { JSON->new->relaxed->utf8->decode( $req->params->{extra} ) };
+        = eval { JSON::MaybeXS->new->relaxed->utf8->decode( $req->params->{extra} ) };
     $data->{donation} = undef unless ( $req->params->{donations} );
 
     my $res

lib/MetaCPAN/Web/Controller/Search/AutoComplete.pm

@@ -1,6 +1,7 @@
 package MetaCPAN::Web::Controller::Search::AutoComplete;
 
 use Moose;
+use JSON::MaybeXS ();
 use namespace::autoclean;
 
 BEGIN { extends 'MetaCPAN::Web::Controller' }
@@ -11,7 +12,7 @@ sub index : Path {
     my $query = join( q{ }, $c->req->param('q') );
     my $data  = $model->autocomplete($query)->recv;
     $c->res->content_type('application/json');
-    $c->res->body( JSON::encode_json( $data->{results} ) );
+    $c->res->body( JSON::MaybeXS::encode_json( $data->{results} ) );
 }
 
 1;

lib/MetaCPAN/Web/Model/API.pm

@@ -6,7 +6,7 @@ extends 'Catalyst::Model';
 has [qw(api api_secure)] => ( is => 'ro' );
 
 use Encode ();
-use JSON;
+use JSON::MaybeXS;
 use HTTP::Request ();
 use AnyEvent::Curl::Multi;
 use Try::Tiny 0.09;

lib/MetaCPAN/Web/View/HTML.pm

@@ -9,7 +9,7 @@ use Digest::MD5 qw(md5_hex);
 use Digest::SHA1;
 use URI;
 use URI::QueryParam;
-use JSON;
+use JSON::MaybeXS;
 use Gravatar::URL;
 use Regexp::Common qw(time);
 use Template::Plugin::DateTime;
@@ -90,7 +90,7 @@ Template::Alloy->define_vmethod( 'text',
 Template::Alloy->define_vmethod(
     'hash',
     pretty_json => sub {
-        JSON->new->utf8->pretty->encode(shift);
+        JSON::MaybeXS->new->utf8->pretty->encode(shift);
     }
 );
 
@@ -138,7 +138,7 @@ Template::Alloy->define_vmethod(
 Template::Alloy->define_vmethod(
     'array',
     json => sub {
-        JSON::encode_json(shift);
+        JSON::MaybeXS::encode_json(shift);
     }
 );
 

t/controller/search/autocomplete.t

@@ -4,7 +4,7 @@ use utf8;
 use Encode qw(encode is_utf8);
 use Test::More;
 use MetaCPAN::Web::Test;
-use JSON::XS;
+use JSON::MaybeXS;
 
 my @tests = (
     [ moose => 'Moose' ],

t/model/release.t

@@ -2,7 +2,7 @@ use strict;
 use warnings;
 
 use Test::More;
-use JSON;
+use JSON::MaybeXS;
 use MetaCPAN::Web;
 
 sub search_release {