Json view errors #1583
Merged
Json view errors #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently errors on booleans.
The error appears to be coming from JSON::Any + JSON not decoding JSON::XS::Boolean (because they aren't JSON::PP::Boolean).
rwstauner
force-pushed
the
json-view-errors
branch
from
83e062f
to
29387f2
Compare
|
Nice spot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we added the
favorites_as_jsonthing i've been seeing a 500 Error in my console about it.I noticed this week that it is actually killing the Account menu for me.
I am logged in, but b/c the json call fails, the javascript shows me the "Sign in" menu, which is very confusing.
I noticed an error in the log:
and tracked it down to the fact that my user profile has booleans in the "extra" data.