Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed whitespace if rating was non-integer #1659

Merged
merged 1 commit into from Mar 31, 2016
Merged

fixed whitespace if rating was non-integer #1659

merged 1 commit into from Mar 31, 2016

Conversation

oalders
Copy link
Member

@oalders oalders commented Mar 20, 2016

Rebased version of #1637

@oalders oalders mentioned this pull request Mar 20, 2016
Closed
@haarg
Copy link
Member

haarg commented Mar 20, 2016

The <span class="rating-<% stars * 10 %>"> tag is unclosed in this. It should be closed immediately after it is opened.

@oalders
Copy link
Member Author

oalders commented Mar 30, 2016

@haarg is this better?

@oalders oalders merged commit 423ae61 into master Mar 31, 2016
@oalders oalders deleted the pr/1637 branch March 31, 2016 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oalders @haarg @mephinet