Short-circuit correctly in search_expanded #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total will always be the number of documents matched, not the number of documents returned for the given page. Instead, do what search_collapsed does and check if we have any distributions. Additionally, guard search_descriptions against an empty id list, which produces invalid queries. I found these while tracking down the cause of thousands of 500s on /file/_search, ultimately being triggered by a web crawler.
tsibley
force-pushed
the
tsibley/malformed-file-search
branch
from
1418a7a
to
5e259db
Compare
|
This is now passing that I've tidied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total will always be the number of documents matched, not the number
of documents returned for the given page. Instead, do what
search_collapsed does and check if we have any distributions.
Additionally, guard search_descriptions against an empty id list, which
produces invalid queries.
I found these while tracking down the cause of thousands of 500s on
/file/_search, ultimately being triggered by a web crawler.